Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable test forking by default while upgrading to sbt 0.12.2-RC2 #654

Merged
merged 1 commit into from Jan 9, 2013

Conversation

pk11
Copy link
Contributor

@pk11 pk11 commented Jan 7, 2013

No description provided.

@guillaumebort
Copy link
Contributor

Have you tried it? No more blocked JVM while running the Play test suite?

@pk11
Copy link
Contributor Author

pk11 commented Jan 7, 2013

@guillaumebort yeah, I ran runtests and all tests passed.

@guillaumebort
Copy link
Contributor

Ok so let's merge it.

@jroper
Copy link
Member

jroper commented Jan 9, 2013

Tests pass for me too.

jroper added a commit that referenced this pull request Jan 9, 2013
re-enable test forking by default while upgrading to sbt 0.12.2-RC2
@jroper jroper merged commit 5b9adbc into playframework:master Jan 9, 2013
@betehess
Copy link
Contributor

Since this commit, my own tests now hang. It's ok when I override with fork in Test := false.

I'm wondering if this is a problem in my own code (or a library I use) or if there is still a problem with sbt. What kind of information would you need to investigate?

@jroper
Copy link
Member

jroper commented Jan 10, 2013

Have you updated project/build.properties to say:

sbt.version=0.12.2-RC2

@betehess
Copy link
Contributor

My bad... It's like it's written explicitly in the message commit but my brain didn't process it... Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants